HomePhabricator

rpc: Push down safe mode checks

Description

rpc: Push down safe mode checks

Summary:
This contains most of the changes of 10563 "remove safe mode", but doesn't
remove the safe mode yet, but put an ObserveSafeMode() check in
individual calls with okSafeMode=false.

This cleans up the ugly "okSafeMode" flag from the dispatch tables,
which is not a concern for the RPC server.

Extra-author: Wladimir J. van der Laan <laanwj@gmail.com>

This is a backport of Core PR11179

Test Plan:

make check
./test/functional/test_runner.py

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1917

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Jun 9 2017, 00:38
deadalnixCommitted on Oct 11 2018, 10:45
deadalnixPushed on Oct 11 2018, 10:45
Reviewer
Restricted Project
Differential Revision
D1917: rpc: Push down safe mode checks
Parents
rABCb3a4891b12a5: [cmake] Check for the presence of various headers in cmake
Branches
Unknown
Tags
Unknown

Event Timeline

deadalnix committed rABC0e05d72275d7: rpc: Push down safe mode checks (authored by Andrew Chow <achow101-github@achow101.com>).Oct 11 2018, 10:45