HomePhabricator

random: stop retrieving random bytes from OpenSSL

Description

random: stop retrieving random bytes from OpenSSL

Summary:

On the ::SLOW path we would use OpenSSL as an additional source of
random bytes. This commit removes that functionality. Note that this was
always only an additional source, and that we never checked the return
value

RAND_bytes():
https://www.openssl.org/docs/manmaster/man3/RAND_bytes.html

RAND_bytes() puts num cryptographically strong pseudo-random bytes into
buf.

Partial backport of core PR17265:
https://github.com/bitcoin/bitcoin/pull/17265/commits/4fcfcc294e7cb17956e283d09050cb997093a35d

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6241

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Oct 26 2019, 12:22
FabienCommitted on May 25 2020, 14:44
FabienPushed on May 25 2020, 14:44
Reviewer
Restricted Project
Differential Revision
D6241: random: stop retrieving random bytes from OpenSSL
Parents
rABC8d6b4a37ad9d: random: stop feeding RNG output back into OpenSSL
Branches
Unknown
Tags
Unknown