HomePhabricator

Rework addnode behaviour
1111b80df84aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Rework addnode behaviour

  • Use CNode::addeName to track whether a connection to a name is already open
    • A new connection to a previously-connected by-name addednode is only opened when the previous one closes (even if the name starts resolving to something else)
    • At most one connection is opened per addednode (even if the name resolves to multiple)
  • Unify the code between ThreadOpenAddedNodeConnections and getaddednodeinfo
    • Information about open connections is always returned, and the dns argument becomes a dummy
    • An IP address and inbound/outbound is only reported for the (at most 1) open connection

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on May 28 2016, 13:32
deadalnixPushed on May 14 2017, 22:04
Parents
rABCbe9711e59707: Merge #7749: Enforce expected outbound services
Branches
Unknown
Tags
Unknown

Event Timeline

Pieter Wuille <pieter.wuille@gmail.com> committed rABC1111b80df84a: Rework addnode behaviour (authored by Pieter Wuille <pieter.wuille@gmail.com>).Jun 13 2016, 21:53