Diffusion Bitcoin ABC 12025bba2389

[avalanche] Don't include validation.h via proof.h
12025bba2389
Actions

Description

[avalanche] Don't include validation.h via proof.h

Summary:
Lots of test files rely on this indirect inclusion which is bad. Remove the header from proof.h and update accordingly.

Depends on D17837.

Test Plan:

ninja all check

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17838

Details

Provenance

Fabien	Authored on Thu, Mar 20, 09:24
Fabien	Pushed on Thu, Mar 20, 13:09

Reviewer

Restricted Project

Differential Revision

D17838: [avalanche] Don't include validation.h via proof.h

Parents

rABC4b3f043b53d9: [avalanche] Add some missing headers

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABC12025bba2389: [avalanche] Don't include validation.h via proof.h (authored by Fabien).Thu, Mar 20, 13:09

Fabien added an edge: D17838: [avalanche] Don't include validation.h via proof.h.

teamcity mentioned this in T3773: Build Bitcoin-ABC / Master / Sanitizers / Fuzzer is broken..Thu, Mar 20, 13:13

Changes (10)

Path

Size

src/

avalanche/

proof.cpp

proof.h

test/

compactproofs_tests.cpp

delegation_tests.cpp

processor_tests.cpp

proofcomparator_tests.cpp

proofpool_tests.cpp

stakecontendercache_tests.cpp

stakingrewards_tests.cpp

util.h

rABC12025bba2389

View Options

src/avalanche/proof.cpp

View Options

src/avalanche/proof.h

View Options

src/avalanche/test/compactproofs_tests.cpp

View Options

src/avalanche/test/delegation_tests.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/avalanche/test/proofcomparator_tests.cpp

View Options

src/avalanche/test/proofpool_tests.cpp

View Options

src/avalanche/test/stakecontendercache_tests.cpp

View Options

src/avalanche/test/stakingrewards_tests.cpp

View Options

[avalanche] Don't include validation.h via proof.h12025bba2389Actions

Description

Details

Event Timeline

Changes (10)

rABC12025bba2389

src/avalanche/proof.cpp

src/avalanche/proof.h

src/avalanche/test/compactproofs_tests.cpp

src/avalanche/test/delegation_tests.cpp

src/avalanche/test/processor_tests.cpp

src/avalanche/test/proofcomparator_tests.cpp

src/avalanche/test/proofpool_tests.cpp

src/avalanche/test/stakecontendercache_tests.cpp

src/avalanche/test/stakingrewards_tests.cpp

src/avalanche/test/util.h

[avalanche] Don't include validation.h via proof.h
12025bba2389
Actions