HomePhabricator

gui: explicitly disable "Dark Mode" appearance on macOS

Description

gui: explicitly disable "Dark Mode" appearance on macOS

Summary:

Bitcoin Core's gui is pretty broken for a someone using macOS in "Dark
Mode"; the biggest issue being lots of white text on a white background,
leaving most inputs, the rpc console etc unusable.

This is likely something we'll have to wait for Qt to fix/support, so
it's probably easiest to just disable for now, rather than provide a
broken UI; see screenshots below. This issue might not have come up much
yet, given the issues with the 0.17.0 dmg.

Backport of core PR14593.

Test Plan:
Build on OSX with dark theme enabled and check the app use the light
theme.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8336

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Oct 28 2018, 13:35
FabienCommitted on Nov 9 2020, 19:10
FabienPushed on Nov 9 2020, 19:11
Reviewer
Restricted Project
Differential Revision
D8336: gui: explicitly disable "Dark Mode" appearance on macOS
Parents
rABC03c8acb87d90: qt: Use SynchronizationState enum for signals to GUI
Branches
Unknown
Tags
Unknown