HomePhabricator

build: mac deployment unification

Description

build: mac deployment unification

Summary:
core#20333

depends: native_ds_store 1.3.0

native_ds_store now takes advantage of Pythons ability to decode binary
plists (since 3.4), so we can drop its biplist dependency.

The call to biplist.Data() in custom_dsstore doesn't seem to do anything,
and from what I can tell can just be removed.


core#20422

build: automatically determine macOS translations

Rather than using OSX_QT_TRANSLATIONS which must be manually updated,
and we forget to update anyway, i.e: #19059, automatically find and copy
available translations from the translations directory.

macdeploy: remove codesigning argument

macdeploy: remove add-resources argument

macdeploy: have a single level of logging output

4 different levels of verbosity is overkill for a fairly simple script, which
was always being run at 2 in any case.

macdeploy: assume plistlib is available

We already require Python 3.5 or later

macdeploy: consolidate .DS_Store generation

Rather than two lots of logic doing roughly the same thing, dependent on if
you're compiling on Linux or macOS, combine the .DS store generation into
macdeployqtplus.

This also removes the -fancy and -volname options.

macdeploy: move qt_conf to where it's used

macdeploy: remove existing Bitcoin-ABC.dmg if present

macdeploy: remove runHDIUtil in favor of directly calling subprocess.run

macdeploy: use Python 3.6 f-strings

build: mac_alias 2.1.1

This is a backport of core#20422 and core#20333

Test Plan: gitian-osx build-osx

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D13956

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Nov 7 2020, 08:58
PiRKCommitted on Jun 1 2023, 20:51
PiRKPushed on Jun 1 2023, 20:51
Reviewer
Restricted Project
Differential Revision
D13956: build: mac deployment unification
Parents
rABCe9aae6bb4e04: Remove mempool tx package limits
Branches
Unknown
Tags
Unknown