HomePhabricator

util: Disallow network-qualified command line options

Description

util: Disallow network-qualified command line options

Summary:

Command line options prefixed with main/test/regtest network names like -main.port=8333 -test.server=1 previously were allowed but ignored. Now they trigger "Invalid parameter" errors on startup.

This is a backport of Core PR17482

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8739

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Dec 22 2020, 14:23
PiRKCommitted on Dec 22 2020, 14:23
abc-botPushed on Dec 22 2020, 14:27
Reviewer
Restricted Project
Differential Revision
D8739: util: Disallow network-qualified command line options
Parents
rABC736e9068fc07: Tests: Use self.chain instead of 'regtest' in all current tests
Branches
Unknown
Tags
Unknown