HomePhabricator

Just pass a TxId to AddInventoryKnown, rename to AddKnownTx

Description

Just pass a TxId to AddInventoryKnown, rename to AddKnownTx

Summary:

Since it's only used for transactions, there's no need to pass in an inv
type.

Backport of core PR18044.

Since thie PR is Segwit related, there is not much left.
Full commits:

Only the CInv equality operator in messages.py is relevant:

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8501

Details

Provenance
Suhas Daftuar <sdaftuar@gmail.com>Authored on Jan 30 2020, 16:12
FabienCommitted on Nov 24 2020, 09:45
FabienPushed on Nov 24 2020, 09:46
Reviewer
Restricted Project
Differential Revision
D8501: Just pass a TxId to AddInventoryKnown, rename to AddKnownTx
Parents
rABC7577f721476c: Add a prettier linter for the web tools
Branches
Unknown
Tags
Unknown