HomePhabricator

[qa] Split out transaction creation from next_block in functional test

Authored by jasonbcox on Oct 16 2018, 18:00.

Description

[qa] Split out transaction creation from next_block in functional test

Summary:
This allows the easy creation of a tx to be used in this test without requiring next_block() to be called.
next_block() changes self.tip as a side effect, which is unexpected when only a tx is desired. This forces the test
writer to call tip(...) after generating invalid txs to bring the tip back to a good state. This is a bad code smell.

Test Plan: test_runner.py abc-magnetic-anomaly-activation

Reviewers: deadalnix, schancel, #bitcoin_abc

Reviewed By: schancel, #bitcoin_abc

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1930

Details

Committed
jasonbcoxOct 16 2018, 22:32
Pushed
jasonbcoxOct 16 2018, 22:32
Reviewer
Restricted Project
Differential Revision
D1930: [qa] Split out transaction creation from next_block in functional test
Parents
rABCa46b1d0e35dd: Add OSX keystroke to clear RPCConsole
Branches
Unknown
Tags
Unknown