Paths

Table of Contentst

Use spans of std::byte in serialize
16755cd2a145
Actions

Description

Use spans of std::byte in serialize

Summary:
This switches .read() and .write() to take spans of bytes.

This is a backport of core#23438
https://github.com/bitcoin/bitcoin/pull/23438/commits/fa24493d6394b3a477535f480664c9596f18e3c5

Depends ib D15934

Test Plan:
ninja all check-all bitcoin-fuzzers bench-bitcoin

Run the seeder for a few minutes, make sure it finds nodes

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15935

Details

Provenance

MarcoFalke <falke.marco@gmail.com>	Authored on Jan 2 2022, 10:31
PiRK	Committed on Apr 11 2024, 10:10
PiRK	Pushed on Apr 11 2024, 10:10

Reviewer

Restricted Project

Differential Revision

D15935: Use spans of std::byte in serialize

Parents

rABC4d6d2035e110: span: Add BytePtr helper

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABC16755cd2a145: Use spans of std::byte in serialize (authored by MarcoFalke <falke.marco@gmail.com>).Apr 11 2024, 10:10

PiRK added an edge: D15935: Use spans of std::byte in serialize.

teamcity mentioned this in T3523: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken..Apr 11 2024, 10:38

teamcity mentioned this in T3524: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Linux is broken..Apr 11 2024, 12:13

teamcity mentioned this in T3525: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Windows is broken..Apr 11 2024, 12:19

Changes (28)

Path

Size

src/

bench/

common/

script/

seeder/

test/

message_writer_tests.cpp

util.h

serialize.h

streams.h

support/

allocators/

test/

fuzz/

wallet/

rABC16755cd2a145

View Options

src/bench/checkblock.cpp

View Options

src/bench/rpc_blockchain.cpp

View Options

src/common/bloom.cpp

View Options

src/dbwrapper.h

View Options

src/hash.h

View Options

src/net.cpp

View Options

src/psbt.cpp

View Options

src/pubkey.h

View Options

src/script/bitcoinconsensus.cpp

View Options

src/script/interpreter.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/seeder/messagewriter.h

View Options

src/seeder/test/message_writer_tests.cpp

View Options

src/seeder/util.h

View Options

src/serialize.h

View Options

src/streams.h

View Options

src/support/allocators/zeroafterfree.h

View Options

src/test/bloom_tests.cpp

View Options

src/test/fuzz/autofile.cpp

View Options

src/test/fuzz/buffered_file.cpp

View Options

src/test/hash_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/serialize_tests.cpp

View Options

src/test/streams_tests.cpp

View Options

src/uint256.h

View Options

src/validation.cpp

View Options

src/wallet/bdb.cpp

View Options

Use spans of std::byte in serialize16755cd2a145Actions

Description

Details

Event Timeline

Changes (28)

rABC16755cd2a145

src/bench/checkblock.cpp

src/bench/rpc_blockchain.cpp

src/common/bloom.cpp

src/dbwrapper.h

src/hash.h

src/net.cpp

src/psbt.cpp

src/pubkey.h

src/script/bitcoinconsensus.cpp

src/script/interpreter.cpp

src/seeder/bitcoin.cpp

src/seeder/messagewriter.h

src/seeder/test/message_writer_tests.cpp

src/seeder/util.h

src/serialize.h

src/streams.h

src/support/allocators/zeroafterfree.h

src/test/bloom_tests.cpp

src/test/fuzz/autofile.cpp

src/test/fuzz/buffered_file.cpp

src/test/hash_tests.cpp

src/test/script_tests.cpp

src/test/serialize_tests.cpp

src/test/streams_tests.cpp

src/uint256.h

src/validation.cpp

src/wallet/bdb.cpp

src/wallet/sqlite.cpp

Use spans of std::byte in serialize
16755cd2a145
Actions