HomePhabricator

fix RPC error replies
16f33f163d4eUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

fix RPC error replies

After pull #4288, RPC messages indicating errors have a Content-Length unrelated
to their actual contents, rendering bitcoin-cli and curl unable to decode the
reply.

This patch sets the Content-Length field based on the actual content returned.

Additionally, pull #4288 clobbered the error descriptions provided in
ErrorReply, which bitcoin-cli relies upon; this patch moves #4288 http-error
descriptions to an HTTPError method, allowing HTTPReply to pass content on
unchanged.

Details

Provenance
kazcw <keziahw@gmail.com>Authored on Jun 29 2014, 01:14
deadalnixPushed on May 14 2017, 22:04
Parents
rABC7b8fc9d8ad47: Merge pull request #4436
Branches
Unknown
Tags
Unknown

Event Timeline

kazcw <keziahw@gmail.com> committed rABC16f33f163d4e: fix RPC error replies (authored by kazcw <keziahw@gmail.com>).Jun 29 2014, 02:16