Merge #12924: Fix hdmaster-key / seed-key confusion
Summary:
6249021d1 [docs] Add release notes for HD master key -> HD seed rename (John Newbery)
79053a5f2 [rpc] [wallet] Add 'hdmasterkeyid' alias return values. (John Newbery)
c75c35141 [refactor] manually change remaining instances of master key to seed. (John Newbery)
Also included the behavioral changes from the scripted commit 131d4450b scripted-diff: Rename master key to seed (John Newbery)
(hdmasterkeyid -> hdseedid)
Pull request description:
Introduces a tiny API change: - RPC API change: Rename "hdmasterkeyid" to "hdseedid", rename "hdmaster" in wallet-dump output to "hdseed" Fixes also a bug: - Bugfix: use "s" instead of the incorrect "m" for the seed-key hd-keypath key metadata
Tree-SHA512: c913252636f213135a3b64df5de5d21844fb9c2d646567c1aad0ec65745188587de26119de99492c67e559bd49fdd9606b54276f00dddb84301785beba58f281
Backport of remainder of Core PR12924 and PR13297 (single typo fix)
https://github.com/bitcoin/bitcoin/pull/12924/
https://github.com/bitcoin/bitcoin/pull/13297/
Depends on D4190
Test Plan:
make check test_runner.py ./bitcoind ./bitcoin-cli help getwalletinfo ./bitcoin-cli help getaddressinfo ./bitcoin-cli help sethdseed
Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc
Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc
Differential Revision: https://reviews.bitcoinabc.org/D4175