HomePhabricator

refactor: Remove negative lock annotations from globals

Description

refactor: Remove negative lock annotations from globals

Summary:

They only make sense for mutexes that are private members. Until cs_main is a private member the negative annotations should be replaced by excluded annotations, which are optional.

This is a backport of core#21598

Test Plan:
With TSAN:

$ git checkout <previous commit hash>
$ ninja &> before.log
$ git checkout pr21598
$ ninja &> after.log
$ grep "negative capability" before.log | wc -l
33
$ grep "negative capability" after.log | wc -l
0

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10187

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Apr 4 2021, 17:55
PiRKCommitted on Sep 23 2021, 12:27
PiRKPushed on Sep 23 2021, 12:27
Reviewer
Restricted Project
Differential Revision
D10187: refactor: Remove negative lock annotations from globals
Parents
rABC1a0050f15e81: [avalanche] Let buildavalancheproof take a payout address
Branches
Unknown
Tags
Unknown