HomePhabricator

Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.

Description

Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.

Summary:
Bench_internal was previously incorrect but wasn't detected by
-DVERIFY until PR #551.

This is a backport of secp256k1's PR591

Test Plan:

cmake -GNinja .. -DCMAKE_C_FLAGS=-DVERIFY
ninja bench-secp256k1-internal

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4986

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Feb 21 2019, 05:58
deadalnixCommitted on Jan 17 2020, 14:06
deadalnixPushed on Jan 17 2020, 14:06
Reviewer
Restricted Project
Differential Revision
D4986: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
Parents
rABC5079f3218b77: travis: Remove unused sudo:false
Branches
Unknown
Tags
Unknown