HomePhabricator

qa: Fix double-negative arg test

Description

qa: Fix double-negative arg test

Summary:
The test is made more robust by not accept trailing characters after 0.
This change was made after the test failed to fail when a bug was introduced (pointer address used instead of the string in a LogPrintf call).

This is a backport of Core PR17893

Test Plan: ninja && test/functional/test_runner.py feature_config_args.py

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8424

Details

Provenance
Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>Authored on Nov 17 2020, 09:30
PiRKCommitted on Nov 17 2020, 09:35
abc-botPushed on Nov 17 2020, 09:35
Reviewer
Restricted Project
Differential Revision
D8424: qa: Fix double-negative arg test
Parents
rABCa4571e1aed8d: gui: Set CConnman byte counters earlier to avoid uninitialized reads
Branches
Unknown
Tags
Unknown

Event Timeline

PiRK committed rABC19458b9aa1e0: qa: Fix double-negative arg test (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).Nov 17 2020, 09:35