HomePhabricator

Merge #12659: Improve Fatal LevelDB Log Messages

Description

Merge #12659: Improve Fatal LevelDB Log Messages

Summary:
f4b68b3f8f Log fatal LevelDB errors more verbosely (Evan Klitzke)

Pull request description:

The `leveldb::Status` class logs the filename of corrupted files, which might be useful when looking at error reports from usres. In theory this is already logged via the `LogPrintf()` statement in `HandleError()`, but that may not always be close to where the final error message is logged, e.g. see https://github.com/bitcoin/bitcoin/issues/11355#issuecomment-340340542 where the log trace provided by the user does not contain that information (and other user comments in the same issue).

This also adds a log message instructing the user to run the process with `-debug=leveldb`, which provides much more verbose error messages about LevelDB internals. This may not really help much, but improving the error messages here can't hurt.

Tree-SHA512: bbdc52f0ae50e77e4d74060f9f77c6a0b10d5fad1da371eec1ad38a499af5fde3a3b34dd915e721f6bbe779a1f9693ab04fd9cdbcfa95c28f2979b4c0df181c9

Backport of Core PR12659
https://github.com/bitcoin/bitcoin/pull/12659/files

Test Plan: make check

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D3734

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Mar 13 2018, 16:16
jasonbcoxCommitted on Jul 25 2019, 15:51
jasonbcoxPushed on Jul 25 2019, 15:51
Reviewer
Restricted Project
Differential Revision
D3734: Merge #12659: Improve Fatal LevelDB Log Messages
Parents
rABC9364c3a392e7: Add a facility to parse and validate script bitfields.
Branches
Unknown
Tags
Unknown