HomePhabricator

rpc: Make sure conn object is always cleaned up
1a445225f663Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

rpc: Make sure conn object is always cleaned up

Make sure conn object always gets cleaned up by using a
boost::shared_ptr.

This makes valgrind happy - before this commit, one connection object
always leaked at shutdown, as well as can avoid other leaks, when
for example an exception happens.

Also add an explicit Close() to the !ClientAllowed path to make it similar
to the normal path (I'm not sure whether it is needed, but it
can't hurt).

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on May 7 2014, 07:24
deadalnixPushed on May 14 2017, 22:04
Parents
rABC0a0cd3455203: rpc: pass errors from async_accept
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rABC1a445225f663: rpc: Make sure conn object is always cleaned up (authored by Wladimir J. van der Laan <laanwj@gmail.com>).May 12 2014, 07:30