HomePhabricator

test: Set catch_system_errors=no on boost unit tests

Description

test: Set catch_system_errors=no on boost unit tests

Summary:
Boost does not handle asserts well in unit tests. Encountering one causes
test_bitcoin to hang indefinitely. This may explain the occassional timeouts we're
experiencing in CI.

See https://www.boost.org/doc/libs/1_68_0/libs/test/doc/html/boost_test/utf_reference/rt_param_reference/catch_system.html

Backport of Core PR18183

Test Plan:
Introduce assert(0); into a unit test, then: ninja check
Pre-patch, ninja check hangs until killed (Ctrl+C).
Post-patch, ninja check errors out as expected.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8014

Details

Provenance
jasonbcoxAuthored on Oct 21 2020, 15:58
abc-botPushed on Oct 21 2020, 16:04
Reviewer
Restricted Project
Differential Revision
D8014: test: Set catch_system_errors=no on boost unit tests
Parents
rABC47b5ef48bcf1: [CI] Build secp256k1 with endomorphism disabled
Branches
Unknown
Tags
Unknown