HomePhabricator

refactor: Declare g_zmq_notification_interface as unique_ptr

Description

refactor: Declare g_zmq_notification_interface as unique_ptr

Summary:
Ensures better memory safety for this global. This came up during
discussion of the following commit, but is not strictly required for its
implementation.

This is a partial backport of core#27125
https://github.com/bitcoin/bitcoin/pull/27125/commits/8ed4ff8e05d61a8e954d72cebdc2e1d1ab24fb84

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16182

Details

Provenance
TheCharlatan <seb.kung@gmail.com>Authored on Apr 17 2023, 08:42
PiRKCommitted on May 21 2024, 15:00
PiRKPushed on May 21 2024, 15:00
Reviewer
Restricted Project
Differential Revision
D16182: refactor: Declare g_zmq_notification_interface as unique_ptr
Parents
rABC44d71a2036b2: [chronik] Wait for the correct tip finalization in chronik_ws_ordering
Branches
Unknown
Tags
Unknown