HomePhabricator

protocol.h: Make enums in GetDataMsg concrete values

Description

protocol.h: Make enums in GetDataMsg concrete values

This concretizes the numbers and adds a comment to make it clear that
these numbers are fixed by the protocol, and may avoid people forgetting
to claim numbers in the future (e.g. issue #8500).

Also gets rid of a weird unused MSG_TYPE_MAX in the middle of the
enumeration (thanks @paveljanik for noticing).

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Oct 4 2016, 15:55
deadalnixPushed on May 14 2017, 22:04
Parents
rABC2c09a5209ab0: protocol.h: Move MESSAGE_START_SIZE into CMessageHeader
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rABC1df311118d79: protocol.h: Make enums in GetDataMsg concrete values (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Oct 5 2016, 11:32