HomePhabricator

Fix a bug where the TeamCity build only reports one of the test_runner runs

Authored by jasonbcox on Jul 17 2019, 21:44.

Description

Fix a bug where the TeamCity build only reports one of the test_runner runs

Summary:
The junit output of each successive test_runner.py run overwrites junit_results.xml.
This leads to a build failure, but tests reporting as passed: https://build.bitcoinabc.org/viewLog.html?buildId=16488&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=buildResultsDiv
It also leads to incorrect test failure reporting, making it impossible to track flaky or spurious test failures.

This diff fixes that by writing each run to it's own output file.

Test Plan:
See the TeamCity build for this diff: https://build.bitcoinabc.org/viewLog.html?buildId=16722&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=testsInfo
In the "View:" dropdown, select tests without grouping by name

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3691

Details

Committed
jasonbcoxJul 18 2019, 01:26
Pushed
jasonbcoxJul 18 2019, 01:26
Reviewer
Restricted Project
Differential Revision
D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs
Parents
rABC4f6623155efe: Merge #11495: [trivial] Make namespace explicit for is_regular_file
Branches
Unknown
Tags
Unknown