HomePhabricator

[logging/documentation] Remove reference to AcceptToMemoryPool from error string

Description

[logging/documentation] Remove reference to AcceptToMemoryPool from error string

Summary:
User-facing error messages should not leak internal implementation
details like function names. Update the MEMPOOL_REJECTED error string
from "Transaction rejected by AcceptToMemoryPool" to the more generic
"Transaction rejected by mempool". Also update the MEMPOOL_ERROR error
message from "AcceptToMemoryPool failed" to the more precise "Mempool
internal error" since this error indicates and internal (e.g.
logic/hardware/etc) failure, and not a transaction rejection.

These error messages are not covered by tests because they are overwritten with more precise error messages from the ATMP validation state in sendrawtransaction.

This is a backport of core#23173
https://github.com/bitcoin/bitcoin/pull/23173/commits/36167faea92c97ddea7403280a5074073c8e5f90

Test Plan: ninja all check check-functional-extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12234

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Nov 3 2021, 12:06
PiRKCommitted on Oct 13 2022, 16:22
PiRKPushed on Oct 13 2022, 16:22
Reviewer
Restricted Project
Differential Revision
D12234: [logging/documentation] Remove reference to AcceptToMemoryPool from error string
Parents
rABCbe412f514243: [validation] Remove comment about AcceptToMemoryPool()
Branches
Unknown
Tags
Unknown