HomePhabricator

[SECP256K1] Autoconf improvements

Description

[SECP256K1] Autoconf improvements

Summary:

See individual commit messages. These are improvements in preparation of
the switch to Cirrus CI. (Maybe I'll just open a PR on top of this one.)

The first commit made the difference between successful build
https://cirrus-ci.com/task/6740575057608704 and unsuccessful build
https://cirrus-ci.com/task/4909571074424832.

I've tested the second commit without cross-compilation and with
cross-compilation for android (#621 (comment))

When working on the autoconf stuff, I noticed two things that I just
want to write down here:

    At some point we should update build-aux/m4/ax_prog_cc_for_build.m4.
This is outdated, and there have been a lot of fixes But the latest
version is broken, so now is probably not the time.
    The latest autoconf 2.70 deprecates AC_PROG_CC_C89. It's not needed
anymore because AC_PROG_CC cares about testing for version support. This
makes autoconf 2.70 output a warning that we should probably just
ignore. We don't want to force users onto 2.70...

Backport of secp256k1#862

Test Plan:

./autogen.sh
./configure
make

I didn't test valgrind from brew on OSX, I have no old enough OSX that
support valgrind.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D9382

Details

Provenance
Tim Ruffing <crypto@timruffing.de>Authored on Dec 23 2020, 21:08
FabienCommitted on Apr 8 2021, 13:20
FabienPushed on Apr 8 2021, 13:22
Reviewer
Restricted Project
Differential Revision
D9382: [SECP256K1] Autoconf improvements
Parents
rABC01ee0628117a: [SECP256K1] Extract the secret key from a keypair
Branches
Unknown
Tags
Unknown