HomePhabricator

[Cashtab] Improve alias error handling

Description

[Cashtab] Improve alias error handling

Summary:
As per feedback in D15466, removing the redundant setIsValidAliasInput(false) calls upon server errors.

The remaining instances of setIsValidAliasInput(false) in handleAliasWalletChange, clearInputForms and handleAliasNameInput are untouched as they are genuine alias validation/availability logic.

Test Plan:

  • npm test
  • Register Alias button is enabled upon input of a valid and available alias, and registers all ok through the confirmation modal.
  • Register Alias button is disabled upon input of a valid but unavailable alias

Reviewers: #bitcoin_abc, bytesofman

Reviewed By: #bitcoin_abc, bytesofman

Differential Revision: https://reviews.bitcoinabc.org/D15483

Details

Provenance
emackAuthored on Feb 18 2024, 22:20
emackPushed on Feb 25 2024, 02:53
Reviewer
Restricted Project
Differential Revision
D15483: [Cashtab] Improve alias error handling
Parents
rABC172e8f3c6d2a: [Cashtab] Bump extension version
Branches
Unknown
Tags
Unknown