HomePhabricator

Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference…

Description

Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functions

Summary: This is a backport of core PR10865

Test Plan:

make check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1876

Details

Provenance
Dag Robole <dag.robole@gmail.com>Authored on Jul 18 2017, 14:24
deadalnixCommitted on Oct 4 2018, 21:03
deadalnixPushed on Oct 4 2018, 21:03
Reviewer
Restricted Project
Differential Revision
D1876: Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functions
Parents
rABC444c2e51ede0: [tests] Update Unit Test for addrman.h/addrman.cpp
Branches
Unknown
Tags
Unknown