HomePhabricator

[Qt] Don't add arguments of sensitive command to console window

Description

[Qt] Don't add arguments of sensitive command to console window

Summary:
At the moment, we hide sensitive command arguments from the console history but not from the console window.
This tiny change will also hide the arguments from the console window.

Especially for "importmulti", this may be a little bit annoying because if one executes a command with invalid arguments, you need to start type in everything again.

Ideally we would only filter the command if sensitive arguments have been used (complicated to implement).

List of sensitive commands:

const QStringList historyFilter = QStringList()
    << "importprivkey"
    << "importmulti"
    << "signmessagewithprivkey"
    << "signrawtransaction"
    << "walletpassphrase"
    << "walletpassphrasechange"
    << "encryptwallet";

}

Backport of Core PR10093
Completes T444

Test Plan: ninja

Reviewers: deadalnix, schancel, #bitcoin_abc

Reviewed By: deadalnix, schancel, #bitcoin_abc

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1965

Details

Provenance
Jonas Schnelli <dev@jonasschnelli.ch>Authored on Mar 27 2017, 08:19
jasonbcoxCommitted on Oct 25 2018, 22:21
jasonbcoxPushed on Oct 25 2018, 22:22
Reviewer
Restricted Project
Differential Revision
D1965: [Qt] Don't add arguments of sensitive command to console window
Parents
rABC6900e805a862: Make tabs toolbar no longer have a context menu
Branches
Unknown
Tags
Unknown