Merge #15746: rpc: RPCHelpMan: Always name dictionary keys
fa26eb5e8f rpc: RPCHelpMan: Always push_name when outer type is an object (MarcoFalke)
fa652b229e rpc: Add some doxygen comments to utils (MarcoFalke)
Pull request description:
Fixes two issues reported in #15737: * > I am very perplexed as to how the code I'm looking at is generating the help text I'm seeing So add documentation * > This is a value for which a key is missing So always serialize the name of the dictionary key if the outer type is a dictionary
ACKs for commit fa26eb:
promag: Tested ACK fa26eb5.
Backport of Core PR15746
ninja ./bitcoind ./bitcoin-cli help > RPCs ./getrpchelps.sh RPCs master
Then on the patched branch:
ninja ./bitcoind ./getrpchelps.sh RPCs patched ./checkrpc.sh RPCs master patched help.diff
Verify changes in help.diff.
Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix
Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix
Differential Revision: https://reviews.bitcoinabc.org/D6231