HomePhabricator

Handle leveldb::DestroyDB() errors on wipe failure
243b80d29235Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Handle leveldb::DestroyDB() errors on wipe failure

Add error checking to CLevelDBWrapper for errors from
leveldb::DestroyDB(). Without it, if unlink() or DeleteFileW() fail to
delete files, they will fail silent. If they fail to delete any files,
CLevelDBWrapper will silently open and read the existing database.

Typically any permissions issues would be caught by leveldb as it churns
through many files as part of its compaction process, but it is
conceivable that this could cause problems on Windows with anti-virus
and indexing software.

Details

Provenance
Adam Weiss <adam@signal11.com>Authored on Aug 12 2015, 23:32
deadalnixPushed on May 14 2017, 22:04
Parents
rABC87f37e259d6d: Merge pull request #6519
Branches
Unknown
Tags
Unknown

Event Timeline

Adam Weiss <adam@signal11.com> committed rABC243b80d29235: Handle leveldb::DestroyDB() errors on wipe failure (authored by Adam Weiss <adam@signal11.com>).Aug 12 2015, 23:40