HomePhabricator

[backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect.

Description

[backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.

Summary:
Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. Remove no-op CClientUIInterface::[signal_name]_disconnect. (practicalswift)

Pull request description:

Resolves #15698.

Changes:
* Remove no-op `CClientUIInterface::[signal_name]_disconnect`.
* Disconnect `BlockNotifyGenesisWait` and `RPCNotifyBlockChange` properly.

Backport of Core PR15699

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7453

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Apr 23 2019, 17:02
majcostaCommitted on Wed, Sep 16, 15:23
majcostaPushed on Wed, Sep 16, 15:23
Reviewer
Restricted Project
Differential Revision
D7453: [backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.
Parents
rABC007128a7f610: Bump bitcoin-abc-qt AUR package version to 0.22.3
Branches
Unknown
Tags
Unknown