HomePhabricator

refactor: Remove redundant file check from AutoFile shift operators

Description

refactor: Remove redundant file check from AutoFile shift operators

Summary:
The shift operators will call the write or read member function, which
already does the check. Also, call sites are free to directly call
::(Un)Serialize(s, obj) to skip this check, so removing it increases
consistency.

This is a partial backport of core#28060
https://github.com/bitcoin/bitcoin/pull/28060/commits/fafe2ca0ce842cd8f0d8135fa8c8bac9b2c72da6

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D18980

Details

Provenance
MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>Authored on Jul 12 2023, 06:54
PiRKCommitted on Sat, Nov 22, 08:33
PiRKPushed on Sat, Nov 22, 08:33
Reviewer
Restricted Project
Differential Revision
D18980: refactor: Remove redundant file check from AutoFile shift operators
Parents
rABC6ba316c7938c: [Cashtab] Only show extension install notification for webapp
Branches
Unknown
Tags
Unknown