Paths

Table of Contentst

Diffusion Bitcoin ABC 25b4445fda46

consensus: move amount.h into consensus
25b4445fda46
Actions

Description

consensus: move amount.h into consensus

Summary:
Move amount.h to consensus/amount.h.
Renames, adds missing and removes uneeded includes.

Also make MAX_MONEY constexpr

This is a backport of core#22951

Test Plan:
ninja all check-all bitcoin-fuzzers bench-bitcoin

grep -r "<amount.h>" src/

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12164

Details

Provenance

fanquake <fanquake@gmail.com>	Authored on Sep 11 2021, 02:29
PiRK	Committed on Oct 10 2022, 08:19
PiRK	Pushed on Oct 10 2022, 08:19

Reviewer

Restricted Project

Differential Revision

D12164: consensus: move amount.h into consensus

Parents

rABC696d5d33e28b: [avalanche] Cleanup the proof voting test

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABC25b4445fda46: consensus: move amount.h into consensus (authored by fanquake <fanquake@gmail.com>).Oct 10 2022, 08:19

PiRK added an edge: D12164: consensus: move amount.h into consensus.

Changes (82)

Path

Size

src/

avalanche/

test/

bench/

	consensus/

consensus/

index/

interfaces/

node/

policy/

primitives/

qt/

test/

paymentservertests.cpp

transactionfilterproxy.h

transactionrecord.h

walletmodeltransaction.h

rpc/

rawtransaction_util.cpp

script/

test/

fuzz/

transaction_tests.cpp

util/

util/

wallet/

test/

coinselector_tests.cpp

wallet.cpp

wallet.h

walletdb.h

rABC25b4445fda46

View Options

src/CMakeLists.txt

View Options

src/amount.cpp

View Options

src/amount.h

View Options

src/avalanche/avalanche.h

View Options

src/avalanche/proof.h

View Options

src/avalanche/test/util.cpp

View Options

src/bench/coin_selection.cpp

View Options

src/bench/duplicate_inputs.cpp

View Options

src/bench/mempool_eviction.cpp

View Options

src/bench/rpc_mempool.cpp

View Options

src/bench/wallet_balance.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/config.h

View Options

src/consensus/amount.cpp

View Options

src/consensus/amount.h

View Options

src/consensus/tx_check.cpp

View Options

src/consensus/tx_verify.cpp

View Options

src/core_write.cpp

View Options

src/feerate.h

View Options

src/index/coinstatsindex.cpp

View Options

src/init.cpp

View Options

src/interfaces/node.h

View Options

src/interfaces/wallet.cpp

View Options

src/interfaces/wallet.h

View Options

src/miner.cpp

View Options

src/miner.h

View Options

src/minerfund.h

View Options

src/net.h

View Options

src/net_processing.cpp

View Options

src/node/coinstats.h

View Options

src/node/psbt.cpp

View Options

src/policy/fees.h

View Options

src/primitives/transaction.cpp

View Options

src/primitives/transaction.h

View Options

src/qt/bitcoinamountfield.h

View Options

src/qt/bitcoingui.h

View Options

src/qt/bitcoinunits.cpp

View Options

src/qt/bitcoinunits.h

View Options

src/qt/coincontroldialog.h

View Options

src/qt/guiutil.h

View Options

src/qt/optionsmodel.h

View Options

src/qt/paymentrequestplus.h

View Options

src/qt/sendcoinsrecipient.h

View Options

src/qt/test/paymentservertests.cpp

View Options

src/qt/transactionfilterproxy.h

View Options

src/qt/transactionrecord.h

View Options

src/qt/walletmodeltransaction.h

View Options

src/qt/walletview.h

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/server.h

View Options

src/rpc/util.cpp

View Options

src/script/sign.cpp

View Options

src/script/standard.h

View Options

src/test/amount_tests.cpp

View Options

src/test/feerate_tests.cpp

View Options

src/test/fuzz/coins_view.cpp

View Options

src/test/fuzz/fee_rate.cpp

View Options

src/test/fuzz/fees.cpp

View Options

src/test/fuzz/integer.cpp

View Options

src/test/fuzz/parse_numbers.cpp

View Options

src/test/fuzz/util.h

View Options

src/test/policy_fee_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/util/setup_common.h

View Options

src/test/validation_tests.cpp

View Options

src/txmempool.h

View Options

src/util/moneystr.cpp

View Options

src/util/moneystr.h

View Options

src/validation.cpp

View Options

src/validation.h

View Options

src/wallet/coinselection.cpp

View Options

src/wallet/coinselection.h

View Options

src/wallet/fees.h

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/coinselector_tests.cpp

View Options

src/wallet/wallet.cpp

View Options

src/wallet/wallet.h

View Options

consensus: move amount.h into consensus25b4445fda46Actions

Description

Details

Event Timeline

Changes (82)

rABC25b4445fda46

src/CMakeLists.txt

src/amount.cpp

src/amount.h

src/avalanche/avalanche.h

src/avalanche/proof.h

src/avalanche/test/util.cpp

src/bench/coin_selection.cpp

src/bench/duplicate_inputs.cpp

src/bench/mempool_eviction.cpp

src/bench/rpc_mempool.cpp

src/bench/wallet_balance.cpp

src/bitcoin-tx.cpp

src/config.h

src/consensus/amount.cpp

src/consensus/amount.h

src/consensus/tx_check.cpp

src/consensus/tx_verify.cpp

src/core_write.cpp

src/feerate.h

src/index/coinstatsindex.cpp

src/init.cpp

src/interfaces/node.h

src/interfaces/wallet.cpp

src/interfaces/wallet.h

src/miner.cpp

src/miner.h

src/minerfund.h

src/net.h

src/net_processing.cpp

src/node/coinstats.h

src/node/psbt.cpp

src/policy/fees.h

src/primitives/transaction.cpp

src/primitives/transaction.h

src/qt/bitcoinamountfield.h

src/qt/bitcoingui.h

src/qt/bitcoinunits.cpp

src/qt/bitcoinunits.h

src/qt/coincontroldialog.h

src/qt/guiutil.h

src/qt/optionsmodel.h

src/qt/paymentrequestplus.h

src/qt/sendcoinsrecipient.h

src/qt/test/paymentservertests.cpp

src/qt/transactionfilterproxy.h

src/qt/transactionrecord.h

src/qt/walletmodeltransaction.h

src/qt/walletview.h

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/server.h

src/rpc/util.cpp

src/script/sign.cpp

src/script/standard.h

src/test/amount_tests.cpp

src/test/feerate_tests.cpp

src/test/fuzz/coins_view.cpp

src/test/fuzz/fee_rate.cpp

src/test/fuzz/fees.cpp

src/test/fuzz/integer.cpp

src/test/fuzz/parse_numbers.cpp

src/test/fuzz/util.h

src/test/policy_fee_tests.cpp

src/test/transaction_tests.cpp

src/test/util/setup_common.h

src/test/validation_tests.cpp

src/txmempool.h

src/util/moneystr.cpp

src/util/moneystr.h

src/validation.cpp

src/validation.h

consensus: move amount.h into consensus
25b4445fda46
Actions