HomePhabricator

Merge #15631: qa: mininode: Clearer error message on invalid magic bytes

Description

Merge #15631: qa: mininode: Clearer error message on invalid magic bytes

Summary:
fab0a68aa2 qa: mininode: Clearer error message on invalid magic bytes (MarcoFalke)

Pull request description:

Old message:
```
ValueError: got garbage b'\xfa\xbf\xb5\xdafeefilter\x00\x00\x00\x08\x00\x00\x00\xe8\x0f\xd1\x9f\xe8\x03\x00\x00\x00\x00\x00\x00'
```

New message:
```
ValueError: magic bytes mismatch: b'\x00\x11"2' != b'\xfa\xbf\xb5\xdapong\x00\x00\x00\x00\x00\x00\x00\x00\x08\x00\x00\x00\x97\xe6\x04\xd2\xff\x00\x00\x00\x00\x00\x00\x00'
```

Backport of Core PR15631

Test Plan:
For sanity:

test_runner.py p2p_invalid_messages

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8032

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Oct 21 2020, 20:42
jasonbcoxCommitted on Oct 21 2020, 20:43
abc-botPushed on Oct 21 2020, 20:47
Reviewer
Restricted Project
Differential Revision
D8032: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes
Parents
rABC594d974a35d2: [build-bot] Persist build info between redeployments
Branches
Unknown
Tags
Unknown