HomePhabricator

[backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using…

Description

[backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using string search

Summary:
85973bcc44f60fe3bbc952557ebf578dd4c475d2 When BIP70 is disabled, get PaymentRequest merchant using string search (Andrew Chow)

Pull request description:

The merchant name is stored in the X.509 certificate embedded in a PaymentRequest. Use some string searching to locate it so that it can be shown to the user in the transaction details when BIP70 support was not configured.

An additional notice is added to the merchant string that indicates the certificate was not verified. When BIP70 is enabled, the certificate would be verified and the merchant name not shown if the certificate was invalid.

Backport of Core PR16852

Test Plan:

cmake -GNinja -DENABLE_BIP70=ON|OFF
ninja all check

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8751

Details

Provenance
Wladimir J. van der Laan <laanwj@protonmail.com>Authored on Oct 1 2019, 09:53
majcostaCommitted on Dec 24 2020, 16:06
majcostaPushed on Dec 24 2020, 16:06
Reviewer
Restricted Project
Differential Revision
D8751: [backport#16852] gui: When BIP70 is disabled, get PaymentRequest merchant using string search
Parents
rABC75d4f4c0c883: [backport#16969] refactor: Remove Qt function to disable menu icons on macOS
Branches
Unknown
Tags
Unknown