HomePhabricator

don't pass the avalanche processor pointer by reference to the TreadImport…

Description

don't pass the avalanche processor pointer by reference to the TreadImport lambda

Summary:
This causes an intermittent ASAN failure. There is probably some undefined behavior involved.

Depends on D16317

Test Plan:

cmake -GNinja .. -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DENABLE_SANITIZERS="address;undefined"
cmake -E env ASAN_OPTIONS=malloc_context_size=0:log_path=stdout ASAN_OPTIONS=detect_stack_use_after_return=1:log_path=stdout ASAN_OPTIONS=check_initialization_order=1:log_path=stdout ASAN_OPTIONS=strict_init_order=1:log_path=stdout LSAN_OPTIONS=suppressions=../test/sanitizer_suppressions/lsan:log_path=stdout python ./test/functional/test_runner.py feature_init

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16319

Details

Provenance
PiRKAuthored on Jun 10 2024, 14:22
PiRKPushed on Jun 10 2024, 15:14
Reviewer
Restricted Project
Differential Revision
D16319: don't pass the avalanche processor pointer by reference to the TreadImport lambda
Parents
rABC1a982a197370: fix a couple of node.avalanche nullptr dereferencing
Branches
Unknown
Tags
Unknown