[Cashtab] Remove tech debt around checking token names for scams
Summary:
Move token name and ticker blacklist items out of currency object (to be fully deprecated) and into a dedicated blacklist.
In the process of creating this diff, found some tech debt that made sense to clean up here.
- No need to have two functions for isProbablyNotAScam for ticker and name, esp since they are both checking each anyway
- Blacklist needs to condition data so that multi-word banned token names are correctly picked up, like 'Lido Staked Ether'
- Blacklist should be exported as a single pre-processed array. Validation function should compare against only one array.
Test Plan:
npm test
npm start and go to create an etoken. Try some scam names and some normal names. See validation error on scam names.
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Subscribers: Fabien
Differential Revision: https://reviews.bitcoinabc.org/D14333