HomePhabricator

refactor: test/bench: dedup SetupDummyInputs()

Description

refactor: test/bench: dedup SetupDummyInputs()

Summary:
The only difference between SetupDummyInputs() in test/transaction_tests.cpp
and the one in bench/ccoins_caching.cpp was the nValue amounts of the outputs,
so we allow to pass those in an extra (fixed-size) array parameter.

This is a backport of Core PR18173

Test Plan: ninja && ninja check && src/bench/bitcoin-bench -filter=CCoins.*

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8773

Details

Provenance
Sebastian Falbesoner <sebastian.falbesoner@gmail.com>Authored on Jan 5 2021, 07:12
PiRKCommitted on Jan 5 2021, 07:13
abc-botPushed on Jan 5 2021, 07:19
Reviewer
Restricted Project
Differential Revision
D8773: refactor: test/bench: dedup SetupDummyInputs()
Parents
rABC65dc830e7675: [avalanche] Add an handy way to build the quorum in the test
Branches
Unknown
Tags
Unknown