HomePhabricator

[avalanche] Fix getavaaddr on OSX

Description

[avalanche] Fix getavaaddr on OSX

Summary:
The OSX machine us very slow on CI and exhibited a couple additional
flakiness in the test:

  • The block generation in the wait_until loop might be repeated so many times that halving occurs and cause the latter test to fail to reach a quorum due to not enough stakes.
  • The improvements from D11834 were not enough to guarantee a 100% success rate on super slow machines, so we are using a double loop to wait for the expected event and fix this issue.

Test Plan:
On OSX and Linux:

./test/functional/test_runner.py abc_p2p_getavaaddr

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D11837

Details

Provenance
FabienAuthored on Aug 9 2022, 08:07
FabienPushed on Aug 9 2022, 16:51
Reviewer
Restricted Project
Differential Revision
D11837: [avalanche] Fix getavaaddr on OSX
Parents
rABCd1eb6034187d: [avalanche] Remove the network bypass flag, make it default for avalanche…
Branches
Unknown
Tags
Unknown