[backport#16839] Pass NodeContext, ConnMan, BanMan references more places
2b8b4bb8e962
Actions

Description

[backport#16839] Pass NodeContext, ConnMan, BanMan references more places

Summary:
So g_connman and g_banman globals can be removed next commit.

https://github.com/bitcoin/bitcoin/pull/16839/commits/e6f4f895d5e42feaf7bfa5f41e80292aaa73cd7d

Partial backport of Core PR16839

Test Plan:

ninja check-all
ninja

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6409

Details

Provenance

Russell Yanofsky <russ@yanofsky.org>	Authored on Sep 17 2019, 22:28
majcosta	Committed on Jun 6 2020, 19:59
majcosta	Pushed on Jun 6 2020, 19:59

Reviewer

Restricted Project

Differential Revision

D6409: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places

Parents

rABC168db81b1d40: Change ismine to take a CWallet instead of CKeyStore

Branches

Unknown

Tags

Unknown

Event Timeline

majcosta committed rABC2b8b4bb8e962: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places (authored by Russell Yanofsky <russ@yanofsky.org>).Jun 6 2020, 19:59

majcosta added an edge: D6409: [backport#16839] Pass NodeContext, ConnMan, BanMan references more places.

Changes (36)

Path

Size

src/

bench/

interfaces/

	node/
	util/

	context.cpp
	string.cpp

node/

context.h

transaction.cpp

transaction.h

qt/

test/

rpc/

test/

util/

wallet/

test/

coinselector_tests.cpp

init_test_fixture.h

ismine_tests.cpp

wallet_test_fixture.h

wallet_tests.cpp

walletdb_tests.cpp

rABC2b8b4bb8e962

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/bench/coin_selection.cpp

View Options

src/bench/wallet_balance.cpp

View Options

src/bitcoind.cpp

View Options

src/init.cpp

View Options

src/init.h

View Options

src/interfaces/chain.cpp

View Options

src/interfaces/chain.h

View Options

src/interfaces/node.cpp

View Options

src/interfaces/node.h

View Options

src/net_processing.cpp

View Options

src/node/context.cpp

View Options

src/node/context.h

View Options

src/node/transaction.cpp

View Options

src/node/transaction.h

View Options

src/qt/test/addressbooktests.cpp

View Options

src/qt/test/addressbooktests.h

View Options

src/qt/test/rpcnestedtests.cpp

View Options

src/qt/test/rpcnestedtests.h

View Options

src/qt/test/test_main.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/test/wallettests.h

View Options

src/rpc/mining.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/util/setup_common.h

View Options

src/wallet/init.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/coinselector_tests.cpp

View Options

src/wallet/test/init_test_fixture.h

View Options

src/wallet/test/ismine_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.h

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/test/walletdb_tests.cpp

[backport#16839] Pass NodeContext, ConnMan, BanMan references more places2b8b4bb8e962Actions

Description

Details

Event Timeline

Changes (36)

rABC2b8b4bb8e962

src/CMakeLists.txt

src/Makefile.am

src/bench/coin_selection.cpp

src/bench/wallet_balance.cpp

src/bitcoind.cpp

src/init.cpp

src/init.h

src/interfaces/chain.cpp

src/interfaces/chain.h

src/interfaces/node.cpp

src/interfaces/node.h

src/net_processing.cpp

src/node/context.cpp

src/node/context.h

src/node/transaction.cpp

src/node/transaction.h

src/qt/test/addressbooktests.cpp

src/qt/test/addressbooktests.h

src/qt/test/rpcnestedtests.cpp

src/qt/test/rpcnestedtests.h

src/qt/test/test_main.cpp

src/qt/test/wallettests.cpp

src/qt/test/wallettests.h

src/rpc/mining.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/test/rpc_tests.cpp

src/test/util/setup_common.h

src/wallet/init.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/coinselector_tests.cpp

src/wallet/test/init_test_fixture.h

src/wallet/test/ismine_tests.cpp

src/wallet/test/wallet_test_fixture.h

src/wallet/test/wallet_tests.cpp

src/wallet/test/walletdb_tests.cpp

[backport#16839] Pass NodeContext, ConnMan, BanMan references more places
2b8b4bb8e962
Actions