HomePhabricator

[seeder] Make unreliable node reasons clear and consistent

Description

[seeder] Make unreliable node reasons clear and consistent

Summary:
This is a partial backport of bchn#1820
https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/merge_requests/1820/diffs?commit_id=8f435c20698488125a5f4d3759f81237acebff93

Note that I don't like the work reliableness, and reliability is already used in this codebase for another concept, so I went for ReliabilityStatus

Depends on D16905

Test Plan:
run the seeder before and after this change, confirm that we get a similar number of good nodes (check for no regression)

ninja bitcoin-seeder check-seeder
src/seeder/bitcoin-seeder -dumpinterval=60

After a few minutes

awk '{ if ($2 == 1) { print } }' dnsseed.dump

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16499

Details

Provenance
PiRKAuthored on Oct 14 2024, 09:51
PiRKPushed on Oct 15 2024, 05:06
Reviewer
Restricted Project
Differential Revision
D16499: [seeder] Make unreliable node reasons clear and consistent
Parents
rABCa0f49bf60e9e: [seeder] Remove variable that is never read
Branches
Unknown
Tags
Unknown