HomePhabricator

[Cashtab] [p8 local msg verify] Deprecate legacy verification function

Description

[Cashtab] [p8 local msg verify] Deprecate legacy verification function

Summary:
T2730

Depends on D12464

Remove the legacy approach at signature verification

There is an unrelated bug where the message signing function is using BCH instead of bchObj. This would be fixed in another diff, except that we would have a build error in this diff if we left bchObj unused. So, I've patched it here.

Test Plan:
npm start
Sign and verify a message in Cashtab
Confirm cashtab.com also verifies the signature

Sign a message in ElectrumABC using an ecash signature
Verify locally with this diff
Verify that cashtab.com calls it false

Reviewers: emack, #bitcoin_abc

Reviewed By: emack, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D12465

Details

Provenance
bytesofmanAuthored on Nov 10 2022, 12:32
bytesofmanPushed on Nov 14 2022, 15:25
Reviewer
Restricted Project
Differential Revision
D12465: [Cashtab] [p8 local msg verify] Deprecate legacy verification function
Parents
rABCcf315a7cc3f1: [Cashtab] [p7 local msg verify] Install published dependency
Branches
Unknown
Tags
Unknown