HomePhabricator

[cmake] Use the protobuf supplied cmake file instead of the cmake supplied one

Description

[cmake] Use the protobuf supplied cmake file instead of the cmake supplied one

Summary:
The cmake one needs to be updated for each version of protobuf that impacts the file generation or dependencies, which can cause discrepeancies. It actually happens on ArchLinux where the latest cmake (3.26) is unable to properly use the latest protobuf (23.4).

This diff uses the protobuf config file instead and its API, which despite being a bit less convenient to use will remain supported and works as well with the cmake supplied package file, so we can keep using it as a backup.

Test Plan:

ninja all check-bitcoin-qt

Run all the cross compilation builds and the gitian builds as well.
Check it fixes the Qt build on ArchLinux.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Subscribers: PiRK, bytesofman

Differential Revision: https://reviews.bitcoinabc.org/D14254

Details

Provenance
FabienAuthored on Jul 11 2023, 21:14
FabienPushed on Jul 12 2023, 13:31
Reviewer
Restricted Project
Differential Revision
D14254: [cmake] Use the protobuf supplied cmake file instead of the cmake supplied one
Parents
rABCe979c1fc065b: [electrum] convert README to markdown
Branches
Unknown
Tags
Unknown