HomePhabricator

[consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig

Description

[consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig

Summary:
PR description:

This is in preparation for adding different signature verification rules,
specifically tapscript (BIP 342), which interprets opcode 0xac and 0xad
as Schnorr signature verifications.

The rationale for backporting this PR into ABC is that extracting a small piece of a huge function into its own function seems positive in itself, even if we don't plan to do the next steps described in the PR discussion.

This is a backport of Core PR18422

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8917

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Jan 15 2021, 10:17
PiRKCommitted on Jan 15 2021, 10:17
abc-botPushed on Jan 15 2021, 10:24
Reviewer
Restricted Project
Differential Revision
D8917: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig
Parents
rABCf39b2c0aa0be: test: Check that the version message does not leak the local address of the node
Branches
Unknown
Tags
Unknown