HomePhabricator

Perform CVerifyDB on pcoinsdbview instead of pcoinsTip
2e280311b87aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Perform CVerifyDB on pcoinsdbview instead of pcoinsTip

Bypassing the main coins cache allows more thorough checking with the same
memory budget.

This has no effect on performance because everything ends up in the child
cache created by VerifyDB itself.

It has bugged me ever since #4675, which effectively reduced the
number of checked blocks to reduce peak memory usage.

  • Pass the coinsview to use as argument to VerifyDB
  • This also avoids that the first pcoinsTip->Flush() after VerifyDB writes a large slew of unchanged coin records back to the database.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Aug 27 2014, 07:20
deadalnixPushed on May 14 2017, 22:04
Parents
rABCf30801afbde7: qt: Add null check in setClientModel(0)
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rABC2e280311b87a: Perform CVerifyDB on pcoinsdbview instead of pcoinsTip (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Aug 27 2014, 07:20