HomePhabricator

walletdb: Ensure that having no database handle is a failure

Description

walletdb: Ensure that having no database handle is a failure

Summary:
Previously having no database handle could still be considered a success
when BerkeleyDatabase and BerkeleyBatch were used for dummy database
things. With dedicated DummyDatabase and DummyBatch classes now, these
should fail.

This is a backport of core#19102 [3/3]
https://github.com/bitcoin/bitcoin/pull/19102/commits/0fcff547d5b47822c13104978fda0c486e596526

Depends on D10049

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D10050

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Jun 18 2020, 15:28
PiRKCommitted on Sep 6 2021, 16:07
PiRKPushed on Sep 6 2021, 16:07
Reviewer
Restricted Project
Differential Revision
D10050: walletdb: Ensure that having no database handle is a failure
Parents
rABC5948655c3381: Remove BDB dummy databases
Branches
Unknown
Tags
Unknown