HomePhabricator

[LINTER] Add a linter to replace `unsigned char` with `uint8_t`

Authored by Fabien on Jul 8 2019, 12:07.

Description

[LINTER] Add a linter to replace unsigned char with uint8_t

Summary:
This is a recurrent issue in reviews, this diffs provides an autofix
linter for this.
It is named afted stdint so that other conversion can be lated added if
needed.

Test Plan:

arc lint --everything # No warning

Edit src/init.cpp to add the line:

unsigned char foo;

anywhere in the file, then run:

arc lint -- src/init.cpp

The linter should catch the line and suggest a fix.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3592

Details

Committed
FabienJul 8 2019, 15:59
Pushed
FabienJul 8 2019, 15:59
Reviewer
Restricted Project
Differential Revision
D3592: [LINTER] Add a linter to replace `unsigned char` with `uint8_t`
Parents
rABC7630f24afa02: Move make check test logs out of tree
Branches
Unknown
Tags
Unknown