HomePhabricator

Merge #12764: doc: Remove field in getblocktemplate help that has never been…

Description

Merge #12764: doc: Remove field in getblocktemplate help that has never been used.

Summary:
ac8a1d092e [RPC] Remove field in getblocktemplate help that has never been used (Conor Scott)

Pull request description:

[BIP 22 - getblocktemplate](https://github.com/bitcoin/bips/blob/master/bip-0022.mediawiki#Transactions%20Object%20Format) specifies an optional flag, `required` if the transaction must be in the block.

Luke's implementation #936 did not include this flag, and it was later added to the help description in #3246 (more than a year later) but the field was still never actually implemented. As far as I can tell, bitcoin core would have never actually included this in a `getblocktemplate` call, so it seems logical to remove it from the help description.

If I am missing something or this is considered harmless - I can close the PR.

Tree-SHA512: f25dda51cc4e1512aff69309be04e3053bdccc1cf03c8d58e8866aa1fdf9d86cc57df872e85528351fc8a8d6d64a8f46a36c513680834762d854f368fbeb0f44

Backport of Core PR12764

Test Plan: ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6015

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jul 22 2018, 13:40
jasonbcoxCommitted on May 8 2020, 22:04
jasonbcoxPushed on May 8 2020, 22:04
Reviewer
Restricted Project
Differential Revision
D6015: Merge #12764: doc: Remove field in getblocktemplate help that has never been used.
Parents
rABC5c16eed3176c: [Automated] Update manpages
Branches
Unknown
Tags
Unknown