HomePhabricator

[tests] Better stderr testing

Description

[tests] Better stderr testing

Summary:

This PR tightens our checking of stderr and will cause tests to fail if
there is any unexpected message in stderr:

  - commit Write stdout/stderr to datadir instead of temp file writes
stderr to a file in the datadir instead of a temporary file. This helps
with debugging in the case of failure.
  - commit Use LIBC_FATAL_STDERR=1 in tests ensures that libc failures
are logged to stderr instead of the terminal.

Backport of core PR12755
https://github.com/bitcoin/bitcoin/pull/12755/files

Depends on D3273
Fixes T540

Test Plan:

./test/functional/test_runner.py --extended

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Maniphest Tasks: T540

Differential Revision: https://reviews.bitcoinabc.org/D3274

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Feb 7 2018, 14:57
FabienCommitted on Jun 10 2019, 21:24
FabienPushed on Jun 10 2019, 21:24
Reviewer
Restricted Project
Differential Revision
D3274: [tests] Better stderr testing
Parents
rABCc0cfdb0c647a: qa: Normalize executable location
Branches
Unknown
Tags
Unknown
Tasks
T540: Backport Core PR12755