HomePhabricator

move sigops counting from CheckBlock to ContextualCheckBlock

Description

move sigops counting from CheckBlock to ContextualCheckBlock

Summary:
Upgrade features can't live in CheckBlock (which doesn't know anything
about the ancestors of the block), and have to live in ContextualCheckBlock.
So in order to deactivate sigops limits, it has to move.

(while we're at it, this simplifies a rather weird loop)

Test Plan: ninja check-extended

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Maniphest Tasks: T704

Differential Revision: https://reviews.bitcoinabc.org/D5061

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Jan 24 2020, 12:28
markblundebergPushed on Jan 27 2020, 05:15
Reviewer
Restricted Project
Differential Revision
D5061: move sigops counting from CheckBlock to ContextualCheckBlock
Parents
rABC87163f66ca2b: split feature_block test into sigops and non-sigops parts
Branches
Unknown
Tags
Unknown

Event Timeline