Make objects in range declarations immutable by default. Avoid unnecessary…
33322f23b3d4
Actions

Description

Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.

Summary:
Make objects in range declarations immutable by default.

Backport of Bitcoin Core PR13249
https://github.com/bitcoin/bitcoin/pull/13249

(D4191 done again)

Test Plan:

make check-all

Reviewers: Fabien, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4221

Details

Provenance

practicalswift <practicalswift@users.noreply.github.com>	Authored on Jun 18 2018, 05:58
fpelliccioni	Committed on Oct 8 2019, 16:08
fpelliccioni	Pushed on Oct 8 2019, 16:08

Reviewer

Restricted Project

Differential Revision

D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.

Parents

rABC50ae4433e7af: cli: Ignore libevent warnings

Branches

Unknown

Tags

Unknown

Event Timeline

fpelliccioni committed rABC33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary… (authored by practicalswift <practicalswift@users.noreply.github.com>).Oct 8 2019, 16:08

fpelliccioni added an edge: D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Changes (26)

Path

Size

src/

qt/

trafficgraphwidget.cpp

transactiondesc.cpp

transactionrecord.cpp

rpc/

blockchain.cpp

net.cpp

test/

coins_tests.cpp

cuckoocache_tests.cpp

wallet/

rABC33322f23b3d4

View Options

src/cuckoocache.h

View Options

src/net_processing.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/peertablemodel.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/splashscreen.cpp

View Options

src/qt/trafficgraphwidget.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/net.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/cuckoocache_tests.cpp

View Options

src/test/dbwrapper_tests.cpp

View Options

src/test/getarg_tests.cpp

View Options

src/test/key_io_tests.cpp

View Options

src/test/skiplist_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/timedata.cpp

View Options

src/txmempool.cpp

View Options

src/validation.cpp

View Options

src/wallet/db.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

Make objects in range declarations immutable by default. Avoid unnecessary…33322f23b3d4Actions

Description

Details

Event Timeline

Changes (26)

rABC33322f23b3d4

src/cuckoocache.h

src/net_processing.cpp

src/qt/bitcoin.cpp

src/qt/bitcoingui.cpp

src/qt/peertablemodel.cpp

src/qt/sendcoinsdialog.cpp

src/qt/splashscreen.cpp

src/qt/trafficgraphwidget.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/rpc/blockchain.cpp

src/rpc/net.cpp

src/test/coins_tests.cpp

src/test/cuckoocache_tests.cpp

src/test/dbwrapper_tests.cpp

src/test/getarg_tests.cpp

src/test/key_io_tests.cpp

src/test/skiplist_tests.cpp

src/test/util_tests.cpp

src/timedata.cpp

src/txmempool.cpp

src/validation.cpp

src/wallet/db.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

Make objects in range declarations immutable by default. Avoid unnecessary…
33322f23b3d4
Actions