HomePhabricator

[ecash-lib] Fix erroneously deleting EccDummy from tests

Description

[ecash-lib] Fix erroneously deleting EccDummy from tests

Summary:
Diff D17640 introduced a subtle and undetected bug: It ran the tx size estimation within tests using real signatures instead of EccDummy. However, the "leftover" calculation always uses EccDummy.

Since Schnorr signatures are fixed length, this was undetected. But for ECDSA signatures, the tests fail, as "real" signatures can have a different length than dummy signatures used for leftover calculation.

This diff restores the old behavoir, and additionally tests size estimation using ECDSA signatures to ensure we cover behavoir this in our tests.

Test Plan: npm run integration-tests

Reviewers: bytesofman, #bitcoin_abc, Fabien

Reviewed By: bytesofman, #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D17916

Details

Provenance
tobias_ruckAuthored on Apr 9 2025, 19:41
tobias_ruckPushed on Apr 17 2025, 13:53
Reviewer
Restricted Project
Differential Revision
D17916: [ecash-lib] Fix erroneously deleting EccDummy from tests
Parents
rABC86362b831598: test: add "Debug" build to slow builds
Branches
Unknown
Tags
Unknown